Change in vdsm[master]: vmstats: Fix cpu usage key names
fromani at redhat.com
fromani at redhat.com
Thu May 14 11:16:10 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vmstats: Fix cpu usage key names
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40845/2/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 88: - _diff(last_sample, first_sample, 'cpu.user')
Line 89: - _diff(last_sample, first_sample, 'cpu.system'),
Line 90: interval)
Line 91:
Line 92: except (KeyError, TypeError, ZeroDivisionError) as e:
> please check if there is any need for TypeError and ZeroDivError nowadays.
This is for me not for Nir :)
I forgot back in time, will check ASAP.
Line 93: logging.exception("CPU stats not available: %s", e)
Line 94:
Line 95:
Line 96: def balloon(vm, stats, sample):
--
To view, visit https://gerrit.ovirt.org/40845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id26c427d67de47cbcc39ddd43ab4cfe8467432c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list