Change in vdsm[master]: stomp: client side subscription
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Thu May 14 07:34:06 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
......................................................................
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 332: self._destination = destination
Line 333: self._client = client
Line 334: self._message_handler = lambda arg: None
Line 335:
Line 336: def setMessageHandler(self, handler):
> did you sign on that? at least call it from the constructor with none. don'
I understand that is not easy to follow which object is actually handling the messages will create docstring to clarify.
Line 337: self._message_handler = handler
Line 338:
Line 339: def send(self, data):
Line 340: headers = {
--
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list