Change in vdsm[master]: stomp: subscription cleanup when connection lost

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed May 13 15:04:44 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: subscription cleanup when connection lost
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/39969/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 406:         return int(round(monotonic_time() * 1000))
Line 407: 
Line 408:     def handle_close(self, dispatcher):
Line 409:         self.connection.close()
Line 410: 
> now you put that? should be in separate patch and get in today.
No it shouldn't it is part of cleanup.
Line 411: 
Line 412: class AsyncClient(object):
Line 413:     log = logging.getLogger("yajsonrpc.stomp.AsyncClient")
Line 414: 


-- 
To view, visit https://gerrit.ovirt.org/39969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list