Change in vdsm[master]: network: allow custom bondOption

phoracek at redhat.com phoracek at redhat.com
Wed May 13 14:56:02 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: network: allow custom bondOption
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40882/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2398:                                 'options': 'custom=foo mode=balance-rr'}},
Line 2399:                 NOCHK)
Line 2400:             self.assertEqual(status, SUCCESS, msg)
Line 2401:             self.assertBondExists(BONDING_NAME, nics)
Line 2402:             with open(NET_CONF_PREF + BONDING_NAME) as f:
> this is terribly specific to the ifcfg configurator. I think that passing t
it check if passed options are subset of real bond options, but i agree, we just have to change it a bit
Line 2403:                 for l in f:
Line 2404:                     if 'BONDING_OPTS' in l:
Line 2405:                         self.assertNotIn('custom=foo', l)
Line 2406:                         self.assertIn('mode=balance-rr', l)


-- 
To view, visit https://gerrit.ovirt.org/40882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list