Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
danken at redhat.com
danken at redhat.com
Wed May 13 14:31:15 UTC 2015
Hello Ondřej Svoboda,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40881
to review the following change.
Change subject: netinfoTests: Do not try to read bonding options
......................................................................
netinfoTests: Do not try to read bonding options
A user running the tests usually does not have sudo permissions
to create a bond.
Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31270
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/netinfoTests.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/40881/1
diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index 3d2c1af..276fe4f 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -115,6 +115,7 @@
@MonkeyPatch(ipwrapper.Link, '_detectType',
partial(_fakeTypeDetection, ipwrapper.Link))
@MonkeyPatch(netinfo, 'networks', lambda: {'fake': {'bridged': True}})
+ @MonkeyPatch(netinfo, '_getBondingOptions', lambda x: {})
def testGetNonExistantBridgeInfo(self):
# Getting info of non existing bridge should not raise an exception,
# just log a traceback. If it raises an exception the test will fail as
--
To view, visit https://gerrit.ovirt.org/40881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
More information about the vdsm-patches
mailing list