Change in vdsm[master]: password: Prevent password logging and persisting

fromani at redhat.com fromani at redhat.com
Wed May 13 13:55:34 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: password: Prevent password logging and persisting
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwordsTests.py:

Line 29: class ProtectedPasswordTests(VdsmTestCase):
Line 30: 
Line 31:     def test_str(self):
Line 32:         p = ProtectedPassword("12345678")
Line 33:         self.assertFalse("12345678" in str(p))
> I will change it in the next version.
Posted the patch mentioned above: https://gerrit.ovirt.org/#/c/40879/
Line 34: 
Line 35:     def test_repr(self):
Line 36:         p = ProtectedPassword("12345678")
Line 37:         self.assertFalse("12345678" in repr(p))


-- 
To view, visit https://gerrit.ovirt.org/40707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list