Change in vdsm[master]: stomp: client side subscription

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed May 13 10:43:26 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: client side subscription
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/36368/19/tests/jsonRpcHelper.py
File tests/jsonRpcHelper.py:

Line 101:                 if handler.NAME == type:
Line 102:                     reactor = handler._reactor
Line 103: 
Line 104:         if not client:
Line 105:             def client(client_socket):
> as above.
We can't define it outside due to reactor instance available only locally in constructClient.
Line 106:                 return StompRpcClient(
Line 107:                     reactor.createClient(client_socket),
Line 108:                     _FAKE_SUB_ID,
Line 109:                     _FAKE_SUB_ID,


-- 
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list