Change in vdsm[master]: netlink: rtnl_put_link after rtnl_link_get_kernel

danken at redhat.com danken at redhat.com
Wed May 13 09:47:39 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: netlink: rtnl_put_link after rtnl_link_get_kernel
......................................................................


netlink: rtnl_put_link after rtnl_link_get_kernel

According to netlink documentation [1] we have to decrement reference
counter when we don't need link (obtained from rtnl_link_get_kernel)
anymore, otherwise we cause a leak.

This bug was found by John Taylor <jtt77777 at gmail.com> [2].

Note that even before [3] was merged, _get_link() failed to call
rtnl_put after yielding the result of rtnl_link_kernel().

[1] http://www.infradead.org/~tgr/libnl/doc/route.html#link_direct_lookup
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1158108#c18
[3] https://gerrit.ovirt.org/#/c/40571/4/lib/vdsm/netlink/link.py

Change-Id: Iefa70103c7c0f218c89abbe5c8371b745064a13e
Bug-Url: https://bugzilla.redhat.com/1158108
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40812
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netlink/link.py
1 file changed, 31 insertions(+), 21 deletions(-)

Approvals:
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/40812
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa70103c7c0f218c89abbe5c8371b745064a13e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: John Taylor <jtt77777 at yahoo.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list