Change in vdsm[master]: vm: Support replication to different storage type

nsoffer at redhat.com nsoffer at redhat.com
Tue May 12 22:00:55 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: Support replication to different storage type
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/40185/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 922:         """
Line 923:         Return extension info for a chunked drive or drive replicating to
Line 924:         chunked replica volume.
Line 925:         """
Line 926:         capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
> Have you tried this with NFS squashed root privileges? As far as I remember
BZ 963881 was fixed in 2013 in this commit:

 commit b4a40dd92dc7e6f110b13f2353cb5343d1147227
 Author:     Martin Kletzander <mkletzan at redhat.com>
 AuthorDate: Fri May 24 18:26:26 2013 +0200
 Commit:     Martin Kletzander <mkletzan at redhat.com>
 CommitDate: Wed Jul 24 14:29:12 2013 +0200

    Use qemuOpenFile in qemu_driver.c
    
    On two places, the usage of open() is replaced with qemuOpenFile as
    that is the preferred method in those cases.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=963881

I will test it on with root_squash.
Line 927: 
Line 928:         # Libvirt reports watermarks only for the source drive, but for
Line 929:         # file-based drives it reports the same alloc and physical, which
Line 930:         # breaks our extend logic. Since drive is chunked, we must have a


-- 
To view, visit https://gerrit.ovirt.org/40185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb93082af81fe54268ee0133d1252c0d537ca8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list