Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
ykaplan at redhat.com
ykaplan at redhat.com
Tue May 12 16:02:17 UTC 2015
Yeela Kaplan has posted comments on this change.
Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/39203/8/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:
Line 75: self._client.close()
Line 76:
Line 77:
Line 78: def connect(client):
Line 79: client = JsonRpcClient(client)
> What do you think about:
possible,
but it gets even longer in next patch in series and I think it's more readable this way...
Line 80:
--
To view, visit https://gerrit.ovirt.org/39203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list