Change in vdsm[master]: stomp: client side subscription
ybronhei at redhat.com
ybronhei at redhat.com
Tue May 12 15:44:45 UTC 2015
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: client side subscription
......................................................................
Patch Set 19:
(3 comments)
https://gerrit.ovirt.org/#/c/36368/19/tests/jsonRpcHelper.py
File tests/jsonRpcHelper.py:
Line 94: xml_handler = [h for h in acceptor._handlers if h.NAME == type]
Line 95: for (method, name) in bridge.getBridgeMethods():
Line 96: xml_handler[0].xml_binding.server.register_function(method,
Line 97: name)
Line 98: client = create
why don't you just return XMLClient? its the same..
Line 99: else:
Line 100: for handler in acceptor._handlers:
Line 101: if handler.NAME == type:
Line 102: reactor = handler._reactor
Line 100: for handler in acceptor._handlers:
Line 101: if handler.NAME == type:
Line 102: reactor = handler._reactor
Line 103:
Line 104: if not client:
this can be under the else where client is still not set anyway
Line 105: def client(client_socket):
Line 106: return StompRpcClient(
Line 107: reactor.createClient(client_socket),
Line 108: _FAKE_SUB_ID,
Line 101: if handler.NAME == type:
Line 102: reactor = handler._reactor
Line 103:
Line 104: if not client:
Line 105: def client(client_socket):
define the function outside and assign it as in the xml case.
Line 106: return StompRpcClient(
Line 107: reactor.createClient(client_socket),
Line 108: _FAKE_SUB_ID,
Line 109: _FAKE_SUB_ID,
--
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list