Change in vdsm[master]: ssl: m2crypto removal

danken at redhat.com danken at redhat.com
Tue May 12 13:24:14 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: ssl: m2crypto removal
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/39990/4/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 177:         if config.getboolean('vars', 'ssl'):
Line 178:             truststore_path = config.get('vars', 'trust_store_path')
Line 179:             protocol = (
Line 180:                 ssl.PROTOCOL_TLSv1
Line 181:                 if config.get('vars', 'ssl_protocol') == 'sslv23'
> We use tlsv1 by default or sslv23 when we asked by used. Default value in c
how is that the same behavior as before? why is this complex logic related to the m2crypto remval?

at the very lease we should document config.py that sslv23 there actually means tlsv11
Line 182:                 else ssl.PROTOCOL_SSLv23
Line 183:             )
Line 184:             sslinfo = SSLInfo(
Line 185:                 key_file=os.path.join(truststore_path, 'keys', 'vdsmkey.pem'),


-- 
To view, visit https://gerrit.ovirt.org/39990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list