Change in vdsm[master]: vm: Detect RNG device by type

smelamud at redhat.com smelamud at redhat.com
Tue May 12 10:44:34 UTC 2015


Shmuel Leib Melamud has posted comments on this change.

Change subject: vm: Detect RNG device by type
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40095/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4174:                     dev.address = address
Line 4175:                     dev.alias = alias
Line 4176: 
Line 4177:             for dev in self.conf['devices']:
Line 4178:                 if dev['device'] == hwclass.SMARTCARD and \
> i think smartcard has the same issue
For smartcard seems to work OK.
Line 4179:                         not dev.get('address'):
Line 4180:                     dev['address'] = address
Line 4181:                     dev['alias'] = alias
Line 4182: 


-- 
To view, visit https://gerrit.ovirt.org/40095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list