Change in vdsm[master]: vm: Support replication to different storage type

Federico Simoncelli fsimonce at redhat.com
Tue May 12 08:27:46 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: vm: Support replication to different storage type
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/40185/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 922:         """
Line 923:         Return extension info for a chunked drive or drive replicating to
Line 924:         chunked replica volume.
Line 925:         """
Line 926:         capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
Have you tried this with NFS squashed root privileges? As far as I remember libvirt runs as root and it won't be able to access the volume (to get the physical size).

If this has been fixed on the libvirt side (maybe it was BZ#963881). please send another patch to use blockInfo also in _diskSizeExtendCow (instead of qemuimg.info).
Line 927: 
Line 928:         # Libvirt reports watermarks only for the source drive, but for
Line 929:         # file-based drives it reports the same alloc and physical, which
Line 930:         # breaks our extend logic. Since drive is chunked, we must have a


-- 
To view, visit https://gerrit.ovirt.org/40185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb93082af81fe54268ee0133d1252c0d537ca8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list