Change in vdsm[master]: All modules configure should run on upgrade

ykaplan at redhat.com ykaplan at redhat.com
Tue May 12 07:37:15 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: All modules configure should run on upgrade
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/39492/5/vdsm.spec.in
File vdsm.spec.in:

Line 950: 
Line 951:     if ! %{_bindir}/vdsm-tool is-configured >/dev/null 2>&1;
Line 952:     then
Line 953:         if ! %{_bindir}/vdsm-tool configure --force \
Line 954:                 >/dev/null 2>&1; then
This change is good,


just a comment for reminder,
when upgrading from earlier versions multipath won't be reconfigured,
since its configuration was done as part of vdsm restart.
Line 955:             # fallback to vdsmd reconfigure api - This change may be removed
Line 956:             # when vdsm won't support any downgrade\upgrade to versions that
Line 957:             # don't include vdsm-tool configure api (vdsm <= 3.3)
Line 958:             for f in '/usr/lib/systemd/systemd-vdsmd' '/etc/init.d/vdsmd'; do


-- 
To view, visit https://gerrit.ovirt.org/39492
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list