Change in vdsm[master]: hsm: Support GUID list param in GetDeviceList

nsoffer at redhat.com nsoffer at redhat.com
Mon May 11 21:37:48 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Support GUID list param in GetDeviceList
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/40661/4//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Add support for additional optional parameter of a list of GUIDs
Line 10: to GetDeviceList.
Line 11: 
Line 12: The possible usages of getDeviceList are:
Replace this with "Examples"
Line 13: getDeviceList
Line 14:     return all devices
Line 15: getDeviceList FCP
Line 16:     return only FCP devices


Line 14:     return all devices
Line 15: getDeviceList FCP
Line 16:     return only FCP devices
Line 17: getDeviceList ISCSI guid1 guid2
Line 18:     return info for guid1 and guid2, assuming ISCSI type
Please indent the examples and add vertical spacing to make it more clear.
Line 19: 
Line 20: Example of usage :
Line 21:     $ vdsClient -s 0 ISCSI getDeviceList 3b4fa3ce90178
Line 22:             360b20097ed8


Line 18:     return info for guid1 and guid2, assuming ISCSI type
Line 19: 
Line 20: Example of usage :
Line 21:     $ vdsClient -s 0 ISCSI getDeviceList 3b4fa3ce90178
Line 22:             360b20097ed8
This is not needed now.
Line 23: 
Line 24: Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Line 25: Bug-Url:https://bugzilla.redhat.com/609689


-- 
To view, visit https://gerrit.ovirt.org/40661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list