Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets

derez at redhat.com derez at redhat.com
Mon May 11 14:36:16 UTC 2015


Daniel Erez has posted comments on this change.

Change subject: ceph: Support ephemeral Libvirt secrets
......................................................................


Patch Set 8:

(3 comments)

https://gerrit.ovirt.org/#/c/40712/8/vdsm/virt/secret.py
File vdsm/virt/secret.py:

Line 48:     # TODO: Use response.success when it is available
Line 49:     return {'status': doneCode}
Line 50: 
Line 51: 
Line 52: def unregister(uuids):
It's probably worth to invoke unregister for all secrets on host upon vdsm restart (to have a clear slate and to correlate to libvirt restart).
Line 53:     try:
Line 54:         uuids = [str(uuid.UUID(s)) for s in uuids]
Line 55:     except ValueError as e:
Line 56:         logging.warning("Attempt to unregister invalid uuid %s: %s" %


Line 91: key
shouldn't we use "value" instead, to accommodate to libvirt's format (https://libvirt.org/formatsecret.html).


Line 92:         
I guess we can drop these for now and just use the default values ('yes'), at least until we decide to support it...


-- 
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list