Change in vdsm[master]: stomp: add an option to create a stomp client

ykaplan at redhat.com ykaplan at redhat.com
Mon May 11 14:09:28 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: stomp: add an option to create a stomp client
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/38491/7/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 441:     def __init__(self, json_binding):
Line 442:         self.json_binding = json_binding
Line 443:         self._reactor = self.json_binding.reactor
Line 444: 
Line 445:     def createClient(self, connected_socket):
> It is better to have this code in clientIF not here. This class is responsi
Done
Line 446:         return self._reactor.createClient(connected_socket)
Line 447: 
Line 448:     def detect(self, data):
Line 449:         return data.startswith(stomp.COMMANDS)


-- 
To view, visit https://gerrit.ovirt.org/38491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list