Change in vdsm[master]: Cache the result of numaUtils.getVcpuPids

danken at redhat.com danken at redhat.com
Mon May 11 12:27:21 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Cache the result of numaUtils.getVcpuPids
......................................................................


Cache the result of numaUtils.getVcpuPids

The method that get the current NUMA cpu assignments
burns quite a lot of CPU cycles to parse the libvirt
XML all the time.

This is not necessary as the XML only needs to be
parsed again after it changes.

This patch adds a NUMA vCpuPids cache to improve
the overall NUMA stats performance.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182094
Change-Id: I135143bccdd29697ec673819212193c0fc217e56
Signed-off-by: Martin Sivak <msivak at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38564
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/numaUtilsTests.py
M vdsm/numaUtils.py
M vdsm/virt/vm.py
3 files changed, 40 insertions(+), 1 deletion(-)

Approvals:
  Martin Sivák: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38564
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I135143bccdd29697ec673819212193c0fc217e56
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list