Change in vdsm[master]: virt: bind console to unix domain socket
fromani at redhat.com
fromani at redhat.com
Mon May 11 11:57:50 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: bind console to unix domain socket
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/40704/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1683: nic.name)
Line 1684:
Line 1685: self._guestEventTime = self._startTime
Line 1686: sampling.stats_cache.add(self.id)
Line 1687:
> nice, but unrelated.
removed
Line 1688: try:
Line 1689: self.guestAgent.connect()
Line 1690: except Exception:
Line 1691: self.log.exception("Failed to connect to guest agent channel")
Line 1760: # we need to complete the initialization, including
Line 1761: # domDependentInit, after the migration is completed.
Line 1762:
Line 1763: if not self.recovering:
Line 1764: self._prepareDevicesForStartup()
> probably this cleanup should be split in a followup patch
kept for now
Line 1765:
Line 1766: if initDomain:
Line 1767: domxml = hooks.before_vm_start(self._buildDomainXML(),
Line 1768: self.conf)
--
To view, visit https://gerrit.ovirt.org/40704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list