Change in vdsm[ovirt-3.5]: bondopts: Add defaults for new bonding options

ybronhei at redhat.com ybronhei at redhat.com
Mon May 11 11:10:46 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: bondopts: Add defaults for new bonding options
......................................................................


bondopts: Add defaults for new bonding options

The new options are:
arp_all_targets, lp_interval, packets_per_slave, tlb_dynamic_lb

Without this patch, they are reported even if they have default values.
This is harmless but quite confusing, as we only want to report options
with values differing from their defaults (which are mode-dependent).

netinfoTests:testGetBondingOptions, whose purpose is to alert
us that we are missing some defaults, should now pass again.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219932
Change-Id: I26874003ab5fe4f4fbe92805ea78b7823b742074
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34637
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
(cherry picked from commit 649c99978aa39491886ebbe2e33683d6b8756b37)
Reviewed-on: https://gerrit.ovirt.org/40725
Continuous-Integration: Jenkins CI
Tested-by: David Caro <dcaroest at redhat.com>
---
M vdsm/bonding-defaults.json
1 file changed, 91 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  David Caro: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26874003ab5fe4f4fbe92805ea78b7823b742074
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list