Change in vdsm[master]: hsm: Support GUID list param in GetDeviceList

nsoffer at redhat.com nsoffer at redhat.com
Mon May 11 09:25:11 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Support GUID list param in GetDeviceList
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40661/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 2027:             elif sd.storageType(storageType) == sd.type2name(sd.FCP_DOMAIN):
Line 2028:                 typeFilter = \
Line 2029:                     lambda dev: multipath.devIsFCP(dev.get("devtype"))
Line 2030:             else:
Line 2031:                 return devices
> I think it is a bug in the original code.
You are correct that no filter is applied, but it is not related to your change. Your change will return empty list if type is unknown, which is different from the original behavior, returning all devices.
Line 2032: 
Line 2033:         pvs = {}
Line 2034:         if guids:
Line 2035:             for guid in guids:


-- 
To view, visit https://gerrit.ovirt.org/40661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list