Change in vdsm[master]: migration: Use jsonrpc during migration of vms

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon May 11 08:14:55 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: migration: Use jsonrpc during migration of vms
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/36701/10/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 128:             config.getint('addresses', 'management_port'))
Line 129:         self.remoteHost, port = hostPort.rsplit(':', 1)
Line 130: 
Line 131:         try:
Line 132:             client_socket = self._createSocket(port)
We can use following code here:

client = cif.createClient(port)
self._destServer = jsonrpcvdscli.connect(client)
Line 133:             json_binding = self._vm.cif.bindings['jsonrpc']
Line 134:             reactor = json_binding.getStompReactor()
Line 135:             self._destServer = jsonrpcvdscli.connect(reactor,
Line 136:                                                      client_socket)


-- 
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list