Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon May 11 07:58:20 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/39203/6/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 74:     def __del__(self):
Line 75:         self._client.close()
Line 76: 
Line 77: 
Line 78: def connect(reactor, client_socket):
Why should we care how to create stompClient. I think it would be better to pass a client, connect and return instance of _Server.
Line 79:     stompClient = reactor.createClient(client_socket)
Line 80:     if stompClient is None:
Line 81:         raise Exception("Failed to create a stomp client")
Line 82: 


-- 
To view, visit https://gerrit.ovirt.org/39203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list