Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets

nsoffer at redhat.com nsoffer at redhat.com
Mon May 11 07:41:35 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ceph: Support ephemeral Libvirt secrets
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/40712/6/lib/vdsm/define.py
File lib/vdsm/define.py:

Line 149:         'message': 'Failed to update ioTune values'}},
Line 150:     'V2VConnection': {'status': {
Line 151:         'code': 65,
Line 152:         'message': 'error connecting to hypervisor'}},
Line 153:     'secretBadRequestErr': {'status': {
I think we need one error for all verbs for bad request. The caller can customize the error message so the client can see useful info about the error.
Line 154:         'code': 66,
Line 155:         'message': 'Bad secret request'}},
Line 156:     'secretRegisterErr': {'status': {
Line 157:         'code': 67,


-- 
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list