Change in vdsm[master]: storage: Add resize map support in multipath.py

nsoffer at redhat.com nsoffer at redhat.com
Mon May 11 07:30:30 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: Add resize map support in multipath.py
......................................................................


Patch Set 11:

(1 comment)

Looks great expect one duplicated line

https://gerrit.ovirt.org/#/c/40468/11/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 104: 
Line 105:     if len(set(size for slave, size in slaves)) != 1:
Line 106:         raise Error("Map %r slaves size differ %s" % (guid, slaves))
Line 107: 
Line 108:     name = devicemapper.getDmId(guid)
We got it in line 97
Line 109:     map_size = getDeviceSize(name)
Line 110:     slave_size = slaves[0][1]
Line 111:     if map_size == slave_size:
Line 112:         return False


-- 
To view, visit https://gerrit.ovirt.org/40468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1020667baeb5976fb1c78daedcc88727648f13d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list