Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

tjeyasin at redhat.com tjeyasin at redhat.com
Mon May 11 06:21:20 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 165: @makePublic
Line 166: def mountMetaVolume(device):
Line 167:     if not os.path.exists(META_VOL_MOUNT_POINT):
Line 168:         try:
Line 169:             os.makedirs(META_VOL_MOUNT_POINT, 0o755)
Why 0o755 ? Any specific reason?
Line 170:         except OSError:
Line 171:             raise ge.GlusterMetaVolumeMountFailedException(
Line 172:                 err=['Mount Point creation failed'])
Line 173: 


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list