Change in vdsm[master]: gluster: revamp in geo-replication status and list verbs.

tjeyasin at redhat.com tjeyasin at redhat.com
Mon May 11 06:05:14 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: revamp in geo-replication status and list verbs.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/39910/2/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1143:                               checkpointTime: 'checkpoint set time'
Line 1144:                               checkpointCompletionTime: 'checkpoint completion
Line 1145:                                                          time'
Line 1146:                               checkpointCompleted: 'yes/no'}]...
Line 1147:                ]....
How are you going to support backward compatibility. Why don't you just add the new fields into the dictionary in addition to the existing and check take new fields if only available.
Line 1148:     }
Line 1149:     """
Line 1150:     status = {}
Line 1151:     for volume in tree.findall('geoRep/volume'):


Line 1193:                 pairDetail['meta'] = pair.find('meta').text
Line 1194:                 pairDetail['failures'] = pair.find('failures').text
Line 1195:                 pairDetail['checkpointCompleted'] = pair.find(
Line 1196:                     'checkpoint_completed').text
Line 1197:                 pairs.append(pairDetail)
Don't we need filesSynced, filesPending, bytesPending, deletesPending, filesSkipped details?
Line 1198:             sessionDetail['bricks'] = pairs
Line 1199:             sessions.append(sessionDetail)
Line 1200:         volumeDetail['sessions'] = sessions
Line 1201:         status[volume.find('name').text] = volumeDetail


-- 
To view, visit https://gerrit.ovirt.org/39910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9405e936b69e9dd4d2ed6621cfc1c70752def26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list