Change in vdsm[master]: gluster: Allow gluster mount with additional servers

nsoffer at redhat.com nsoffer at redhat.com
Sun May 10 01:30:15 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Allow gluster mount with additional servers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40665/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 258
Line 259
Line 260
Line 261
Line 262
Most of the code here is not related to gluster connection, and is about getting gluster volume info. Please move the code related to getting this info elsewhere. This will also avoid the need to test all those private methods, since they will be public method of the object getting the info.

This class should use some gluster volume info function to get the info. Did you look in vdsm/storage/glusterVolume.py? isn't getVolumeInfo what you need?

We should see here very simple flow:

    def connect():
        volinfo = gluster.get_volume_info()
        build mount options using volinfo.backup_servers
        create mount connection
        connect

For testing we can mock the get_volume_info to return what we like, and verify that we run the mount (also mocked) with the correct options.


-- 
To view, visit https://gerrit.ovirt.org/40665
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list