Change in vdsm[master]: hsm: Resizing the device if needed in getDeviceList
nsoffer at redhat.com
nsoffer at redhat.com
Sun May 10 00:32:36 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: hsm: Resizing the device if needed in getDeviceList
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40469/5/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2049: if multipath.resize_if_needed(dev["guid"]):
Line 2050: dev["capacity"] = str(multipath.getDeviceSize(dev["dm"]))
Line 2051: except Exception as err:
Line 2052: self.log.error("Could not resize device %s",
Line 2053: err, exc_info=True)
Use log.exception if you want a traceback, not the non-standard exc_info.
In the log message, we like to see the device guid and dm id. We may or may not have helpful info in err.
Line 2054:
Line 2055: pv = pvs.get(dev.get('guid', ""))
Line 2056: if pv is not None:
Line 2057: pvuuid = pv.uuid
--
To view, visit https://gerrit.ovirt.org/40469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b1b699b1a905e949e98f435f339a21dad640c6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list