Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

danken at redhat.com danken at redhat.com
Sat May 9 20:24:36 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
......................................................................


Move passwd (set saslpassword for libvirt) to vdsm-tool

In this patch we stop calling saslpassword command directly,
instead we move passwd logic to vdsm-tool configure.
with that patch after rpm installation user will need to call configure
to set the sasl libvirt password - therefore we remove those parts from spec,
and update the manual accordingly.

In additional this patch moves all related constants to passwd and replace
usages.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1169338
Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39823
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Jenkins CI
---
M configure.ac
M lib/vdsm/constants.py.in
M lib/vdsm/libvirtconnection.py
M lib/vdsm/tool/Makefile.am
M lib/vdsm/tool/configurators/Makefile.am
A lib/vdsm/tool/configurators/passwd.py
D lib/vdsm/tool/passwd.py
M tests/libvirtconnectionTests.py
M vdsm-tool/vdsm-tool.1.in
M vdsm.spec.in
10 files changed, 87 insertions(+), 112 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list