Change in vdsm[master]: python3: avoid python3-inconsistent syntax

Federico Simoncelli fsimonce at redhat.com
Fri May 8 14:00:45 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: python3: avoid python3-inconsistent syntax
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40215/5/Makefile.am
File Makefile.am:

Line 130: 	$(WHITELIST)
Line 131: 
Line 132: .PHONY: python3
Line 133: python3:
Line 134: 	if [ -x "$(PYTHON3)" ]; then \
Are you relying on -x failing for empty strings as well?
Line 135: 	    PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \
Line 136: 		$(WHITELIST) \
Line 137: 		`find . -name '*.py' -o -name '*.py.in'`; \
Line 138: 	else \


-- 
To view, visit https://gerrit.ovirt.org/40215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list