Change in vdsm[master]: utils: add command execution logging helpers
nsoffer at redhat.com
nsoffer at redhat.com
Fri May 8 13:02:35 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: utils: add command execution logging helpers
......................................................................
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/38831/7/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:
Line 89: return "{0} (cwd {1})".format(_list2cmdline(args), cwd)
Line 90:
Line 91:
Line 92: def retcode_log_line(code, out=None, err=None):
Line 93: return "rv={0!r} out={1!r} err={2!r}".format(code, out, err)
It will be better to keep the current format (SUCCESS/FAILED rc= err=) so we keep the behavior, and introduce a change in the behavior(rv= out= err=) in another patch.
https://gerrit.ovirt.org/#/c/38831/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 694
Line 695
Line 696
Line 697
Line 698
Lets keep this format in this patch, and make it better in another patch.
--
To view, visit https://gerrit.ovirt.org/38831
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04bde10be24457fe12362456e42528f9fd7196
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list