Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

danken at redhat.com danken at redhat.com
Thu May 7 20:41:55 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
......................................................................


Patch Set 8: Code-Review+2

please rebase on top of master. The test failure below is fixed by https://gerrit.ovirt.org/40346


16:38:13 ERROR: testHostSampleHandlesDisappearingVlanInterfaces (samplingTests.InterfaceSampleTests)
16:38:13 ----------------------------------------------------------------------
16:38:13 Traceback (most recent call last):
16:38:13   File "/tmp/run/vdsm/tests/monkeypatch.py", line 132, in wrapper
16:38:13     with MonkeyPatchScope([(module, name, that)]):
16:38:13   File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
16:38:13     return self.gen.next()
16:38:13   File "/tmp/run/vdsm/tests/monkeypatch.py", line 108, in MonkeyPatchScope
16:38:13     patch.apply()
16:38:13   File "/tmp/run/vdsm/tests/monkeypatch.py", line 63, in apply
16:38:13     old = getattr(module, name)
16:38:13 AttributeError: 'module' object has no attribute '_read_password'

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list