Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

ybronhei at redhat.com ybronhei at redhat.com
Thu May 7 14:50:53 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
......................................................................


Patch Set 6:

(1 comment)

replied to the comment

https://gerrit.ovirt.org/#/c/39823/6/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 49: def configure():
Line 50:     script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME)
Line 51:     rc, _, err = utils.execCmd(script, data=libvirt_password())
Line 52:     if rc != 0:
Line 53:         raise RuntimeError("Set password failed: %s" % (err,))
> should we persist the sasl db? Otherwise, we would call configure on every 
we currently run each boot https://github.com/oVirt/ovirt-node-plugin-vdsm/blob/master/hooks/on-boot/01-vdsm-configure

so it won't be an issue..
Line 54: 
Line 55: 
Line 56: def removeConf():
Line 57:     if isconfigured() == YES:


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list