Change in vdsm[master]: utils: add command execution logging helper

Federico Simoncelli fsimonce at redhat.com
Thu May 7 13:46:56 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: utils: add command execution logging helper
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/38831/6/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:

Line 84:         parts.append(arg)
Line 85:     return ' '.join(parts)
Line 86: 
Line 87: 
Line 88: def command_log_line(args, cwd=None):
> It would be nicer in calling code if we rename this
The point here is that what it generates is a log line, it's not in any format that can be used for anything else. If it didn't have the cwd part it could have been shell_format for example.


-- 
To view, visit https://gerrit.ovirt.org/38831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04bde10be24457fe12362456e42528f9fd7196
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list