Change in vdsm[master]: Revert "clusterLock: Make inquire retval consistent"

alitke at redhat.com alitke at redhat.com
Thu May 7 13:29:32 UTC 2015


Adam Litke has posted comments on this change.

Change subject: Revert "clusterLock: Make inquire retval consistent"
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40652/3/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 464: 
Line 465:     def inquire(self):
Line 466:         with self._globalLockMapSync:
Line 467:             hostId, lockFile = self._getLease()
Line 468:             return self.LVER, hostId if lockFile else None
This should have a comment explaining why this ClusterLock implementation has different return semantics than its peers.
Line 469: 
Line 470:     def release(self):
Line 471:         with self._globalLockMapSync:
Line 472:             self.log.info("Releasing local lock for domain %s", self._sdUUID)


-- 
To view, visit https://gerrit.ovirt.org/40652
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21611beaeb430c04ff5678189733d54cb1df6a84
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list