Change in vdsm[master]: storageServer: Run glusterfs in its own cgroup

nsoffer at redhat.com nsoffer at redhat.com
Thu May 7 12:35:50 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storageServer: Run glusterfs in its own cgroup
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40240/3/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 267:     #      - 22180 /usr/bin/glusterfs ...
Line 268:     #    - run-21649.scope
Line 269:     #      - 21692 /usr/bin/glusterfs ...
Line 270:     #
Line 271:     CGROUP = "glusterfs"
> Makes sense. I will check if this works, systemd has strange rules about na
This is the results of using vdsm-glusterfs:

 ├─vdsm.slice
 │ └─vdsm-glusterfs.slice
 │   ├─run-12591.scope
 │   │ └─12634 /usr/sbin/glusterfs ...
 │   └─run-12421.scope
 │     └─12469 /usr/sbin/glusterfs ...

systemd is using - as a directory separator. So vdsm-glusterfs is considered as the glusterfs slice in the vdsm slice in the main slice. You would expect that we will get the slice vdsm/glusterfs, but it creates instead vdsm/vdsm-glusterfs.

I will try another name that make it clear that this is the vdsm-glusterfs slice without creating unneeded vdsm slice.
Line 272: 
Line 273:     def getLocalPathBase(cls):
Line 274:         return os.path.join(MountConnection.getLocalPathBase(), "glusterSD")
Line 275: 


-- 
To view, visit https://gerrit.ovirt.org/40240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list