Change in vdsm[master]: Getting migration statistics NPE

shavivi at redhat.com shavivi at redhat.com
Thu May 7 12:03:52 UTC 2015


Shahar Havivi has uploaded a new change for review.

Change subject: Getting migration statistics NPE
......................................................................

Getting migration statistics NPE

MigrateStats only return progress when monitor thread is alive,
When calling MigrateStats after the thread is dead we get NPE.
(when calling getMigrationStatus verb)

Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/40657/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6741f06..82af239 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1298,7 +1298,7 @@
             'disks': {}}
         if 'pauseCode' in self.conf:
             stats['pauseCode'] = self.conf['pauseCode']
-        if self.isMigrating():
+        if self.isMigrating() and 'progress' in self.migrateStatus():
             stats['migrationProgress'] = self.migrateStatus()['progress']
 
         decStats = {}


-- 
To view, visit https://gerrit.ovirt.org/40657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list