Change in vdsm[master]: utils: add command execution logging helper

ybronhei at redhat.com ybronhei at redhat.com
Thu May 7 09:02:27 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: utils: add command execution logging helper
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/38831/5/tests/utilsTests.py
File tests/utilsTests.py:

Line 621:         args = ['/usr/bin/dd', 'iflag=direct',
Line 622:                 'if=/dev/a70a4106-24f2-4599-be3e-934fee6e4499/metadata',
Line 623:                 'bs=4096', 'count=1']
Line 624:         line = ' '.join(args)
Line 625:         self.assertEquals(cmdutils._list2cmdline(args), line)
should move to cmdutilsTests.py
Line 626: 
Line 627:     def test_whitespace(self):
Line 628:         args = ['a b', ' c ', 'd\t', '\ne']
Line 629:         line = "'a b' ' c ' 'd\t' '\ne'"


-- 
To view, visit https://gerrit.ovirt.org/38831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04bde10be24457fe12362456e42528f9fd7196
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list