Change in vdsm[master]: ssl: m2crypto removal

ybronhei at redhat.com ybronhei at redhat.com
Thu May 7 07:57:39 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: m2crypto removal
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

see my comment and consider using sslv23. except that the patch looks ok. Juan can you review as well again?

https://gerrit.ovirt.org/#/c/39990/4/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 64: 
Line 65: 
Line 66: class SSLInfo(object):
Line 67:     def __init__(self, cert_file, key_file, ca_certs=None,
Line 68:                  protocol=ssl.PROTOCOL_TLSv1):
I'm not sure if we should keep the sslv23 - it should prefer tlsv1 anyway (see https://bugzilla.redhat.com/show_bug.cgi?id=1212344 and https://docs.python.org/2/library/ssl.html) - if you can verify as well over el6 and close that bug as well it can be great
Line 69:         self.cert_file = cert_file
Line 70:         self.key_file = key_file
Line 71:         self.ca_certs = ca_certs
Line 72:         self.protocol = protocol


-- 
To view, visit https://gerrit.ovirt.org/39990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list