Change in vdsm[master]: ceph: Validate network disk parameters

nsoffer at redhat.com nsoffer at redhat.com
Wed May 6 16:20:04 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ceph: Validate network disk parameters
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40477/2/tests/vmStorageTests.py
File tests/vmStorageTests.py:

Line 230: 
Line 231:     def test_network_disk_no_hosts(self):
Line 232:         self.check(diskType=DISK_TYPE.NETWORK, protocol='rbd')
Line 233: 
Line 234:     def test_network_disk_no_hosts(self):
> Thanks Francesco! Copy and paste is evil :-)
Francesco, current version should address your concerns. Please review again.
Line 235:         self.check(diskType=DISK_TYPE.NETWORK, hosts=[{}])
Line 236: 
Line 237:     def check(self, **kw):
Line 238:         conf = drive_config(**kw)


-- 
To view, visit https://gerrit.ovirt.org/40477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b10c54ba2732ee75e0e55c67e5e8c7bdfafa41d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list