Change in vdsm[master]: vm: disappeared domain are not ready for commands

danken at redhat.com danken at redhat.com
Tue May 5 10:16:02 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: disappeared domain are not ready for commands
......................................................................


vm: disappeared domain are not ready for commands

It is possible that isDomainReadyForCommands races
agains the shutdown path.
The two operations are intrinsically asynchronous with
each other (shutdown, if started from the outside, will
always be asynchronous with everything).

To make code more robust, we add one protection layer
inside isDomainReadyForCommands, catching libvirtErrors
for inexistent domains (no longer existent domains).

It is fair to report that those domains aren't ready
for commands.

Along the way, we add tests to cover all the paths
in Vm.isDomainReadyForCommands().

Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39370
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M tests/vmfakelib.py
M vdsm/virt/vm.py
3 files changed, 43 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/39370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list