Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...

danken at redhat.com danken at redhat.com
Tue May 5 09:25:13 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/40456/3/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 763:     rc, _, _ = utils.execCmd([constants.EXT_IFDOWN, iface], raw=True)
Line 764:     return rc
Line 765: 
Line 766: 
Line 767: def ifup(iface=None, iface_name=None):
> And yes, as I state in the previous commit, since 'async' was not used by c
Sorry - I cannot accept the polymorphism of this function. It would have to verify that only one of its args is non-None, and has a different functionality for each.

In my book this is a not a good spec for a function.

Please introduce the asych->blocking rename in one patch.
Then, add a new module-level function that accepts only a NetDevice and extracts (iface_name, blocking) from it.
Line 768:     "Bring up an interface"
Line 769:     def _ifup(netIf):
Line 770:         rc, out, err = utils.execCmd([constants.EXT_IFUP, netIf], raw=False)
Line 771: 


-- 
To view, visit https://gerrit.ovirt.org/40456
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list