Change in vdsm[master]: ceph: Support authentication using libvirt secrets

nsoffer at redhat.com nsoffer at redhat.com
Tue May 5 08:10:51 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ceph: Support authentication using libvirt secrets
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/40505/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 2572: # @username:  Identifies the username
Line 2573: #
Line 2574: # @type:      Libvirt secret object type
Line 2575: #
Line 2576: # @uuid:      Libvirt secert object uuid
> typo: should be 'secret'
Thanks, will fix in next version.
Line 2577: #
Line 2578: # Since: 4.17.0
Line 2579: ##
Line 2580: {'type': 'NetworkDiskAuthInfo',


https://gerrit.ovirt.org/#/c/40505/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 347:         diskelem.setAttrs(snapshot='no')
Line 348: 
Line 349:         diskelem.appendChild(_getSourceXML(self))
Line 350: 
Line 351:         if hasattr(self, 'auth'):
Relevant only for network disk, check diskType
Line 352:             diskelem.appendChild(self._getAuthXML())
Line 353: 
Line 354:         diskelem.appendChild(self._getTargetXML())
Line 355: 


-- 
To view, visit https://gerrit.ovirt.org/40505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id90dc385059414680aad5a1ae895347351ffbb3f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list