Change in vdsm[master]: network: wait for udev after configuring SRIOV

ibarkan at redhat.com ibarkan at redhat.com
Tue May 5 07:23:50 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: wait for udev after configuring SRIOV
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/40400/6/vdsm/network/api.py
File vdsm/network/api.py:

Line 536:     # that are not yet named by udev or not report all of. This is a blocking
Line 537:     # call that should wait for all udev events to be handled. a proper fix
Line 538:     # should be registering and listening to the proper netlink and udev
Line 539:     # events
Line 540:     time.sleep(0.5)
> Ido, can you add a comment explaining the sleep()?
Done.
Guys, this is ugly and I admitted it. I also added a detailed explanation in gerrit why it is ugly, why I chise this values and how it should be fixed. IMO nsoffer and myself have put enough energy into it so far.
Remember, that although it is ugly, it is pretty harmless. More comments will not make it prettier, and we will fix it when we have the proper bandwidth.
Line 541:     udevadm.settle(timeout=10)
Line 542: 
Line 543: 
Line 544: def _update_numvfs(device_name, numvfs):


-- 
To view, visit https://gerrit.ovirt.org/40400
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list