Change in vdsm[master]: ifcfg: let ifup accept a NetDevice so 'async' flag can be re...

phoracek at redhat.com phoracek at redhat.com
Mon May 4 16:24:56 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: ifcfg: let ifup accept a NetDevice so 'async' flag can be removed
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Only one small question.

It looks good to me together with the following patch.

https://gerrit.ovirt.org/#/c/40478/2/tests/netconfTests.py
File tests/netconfTests.py:

Line 107:             (netinfo, 'NET_CONF_DIR', self._tempdir),
Line 108:             (netinfo, 'NET_CONF_PREF',
Line 109:              os.path.join(self._tempdir, 'ifcfg-')),
Line 110:             (ifcfg, 'ifdown', lambda x: 0),
Line 111:             (ifcfg, 'ifup', lambda **x: 0),
could you shortly describe me, what this double asterisk does?
Line 112:             (libvirt, 'createNetwork', lambda *x: None),
Line 113:             (libvirt, 'removeNetwork', lambda *x: None),
Line 114:         ]):
Line 115:             # after vdsm package is installed, the 'vdsm' account will be


-- 
To view, visit https://gerrit.ovirt.org/40478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list