Change in vdsm[master]: periodic: virt: do not poll storage in migrations

fromani at redhat.com fromani at redhat.com
Mon May 4 16:17:30 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: periodic: virt: do not poll storage in migrations
......................................................................

periodic: virt: do not poll storage in migrations

If we monitor storage during migrations, we
get harmless but scary warning in the logs.

This patch avoids to monitor storage during
migrations to silence logs.

No functionality is lost since monitoring
doesn't do its proper job anyway.

Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/periodic.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/40507/1

diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py
index 8cc5a21..7354926 100644
--- a/vdsm/virt/periodic.py
+++ b/vdsm/virt/periodic.py
@@ -264,7 +264,8 @@
     @property
     def required(self):
         # Avoid queries from storage during recovery process
-        return self._vm.isDisksStatsCollectionEnabled()
+        return (not self._vm.isMigrating() and
+                self._vm.isDisksStatsCollectionEnabled())
 
     @property
     def runnable(self):
@@ -322,7 +323,8 @@
     @property
     def required(self):
         # Avoid queries from storage during recovery process
-        return self._vm.isDisksStatsCollectionEnabled()
+        return (not self._vm.isMigrating() and
+                self._vm.isDisksStatsCollectionEnabled())
 
     @property
     def runnable(self):


-- 
To view, visit https://gerrit.ovirt.org/40507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list