Change in vdsm[master]: vm: Add _findConfDisk() helper

nsoffer at redhat.com nsoffer at redhat.com
Mon May 4 13:34:23 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: Add _findConfDisk() helper
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40217/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2709:                     return device
Line 2710: 
Line 2711:         raise LookupError("No such drive: '%s'" % drive)
Line 2712: 
Line 2713:     def _findConfDisk(self, name):
> To be consistend it should be _findDriveConfigByName
I will rename in the next version.
Line 2714:         devices = self.conf["devices"][:]
Line 2715:         for device in devices:
Line 2716:             if device['type'] == hwclass.DISK and device.get("name") == name:
Line 2717:                 return device


-- 
To view, visit https://gerrit.ovirt.org/40217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3a59a2b798650035870c335ed7c949e2bd431d0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list