Change in vdsm[master]: hooks: ovs

phoracek at redhat.com phoracek at redhat.com
Mon May 4 08:58:24 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/40312/9/vdsm_hooks/ovs/ovs_network_setup.py
File vdsm_hooks/ovs/ovs_network_setup.py:

Line 40: - add 'custom' option to bond (change vdsm API)
Line 41: - pass options to bond via 'custom' entry, OVS modes would not pass checking
Line 42:   + test if passed options are valid (possible injection?)
Line 43: - what happens if someone define one network/bonding with different arguments
Line 44:   multiple times?
- use runningConfig instead of ifaces and ports
Line 45: """
Line 46: import hooking
Line 47: import traceback
Line 48: 


-- 
To view, visit https://gerrit.ovirt.org/40312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list